GUACAMOLE-1170: Use min_size with user stream pool to delay stream index reuse. #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Jan 7, 2026
Contributor
mike-jumper
left a comment
mike-jumper
left a comment
There was a problem hiding this comment.
I think the same changes you've made to the user-specific stream pool also need to be made to the connection-wide stream pool:
guacamole-server/src/libguac/client.c
Lines 284 to 285 in cf09d3a
Other than that, LGTM. Really glad this didn't require changes to guac_pool.
Contributor
Author
|
Since client streams don't receive ack's I wasn't sure if it was worth making the change there. I certainly could for consistencies sake but it's not clear if the same bug could affect client streams too. |
Contributor
|
Good point. I think you're right that the same ambiguity doesn't apply to connection-wide streams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding minimum size to user stream pool, so new stream integers are preferred over reused integers until the minimum size is reached.
This fixes a race condition with stream index reuse outlined in GUACAMOLE-1170.